I’ve started working on documenting our application. So I need to take screenshots of the windows, add them to a document, and write up what each window does. A useful and necessary part of that is a fast tool that lets me annotate an image with arrows and text. Maybe some rectangles. But nothing sophisticated.
The critical aspect is that you never get it right the first time. Or you change the layout of the application window and you need to redo the documentation. If you have to redo all the markup every time the layout changes, you are dead.
So what tool lets you open an image, create a new layer, add text and arrows to the layer, then save the document keep the layers separate so that you can replace the old image with a new image down the road? You also want to be able to select that text, change it and move it, and re-align the arrows.
Tools I considered:
Gimp
ShareX
Paint.net
Inkscape
The tool has to be obvious, because I might go away a year before I come back and have to work on it again. I am going to forget how to do it.
Anyone who has tried to add a rectangle in gimp runs into a WTF: Why is it so difficult and non-obvious? There is no tool to “create a rectangle”. Instead you have to “select a rectangle” then “Fill selection outline”. I’ll never remember that. And it is hard too. Google how to add arrow plugins. I can do all that but it will take me hours to recall all the nuances. Sorry, I gave up after a few hours of crappy results.
ShareX is fast and has excellent basic tools to do what I need. Unfortunately, once you save the file, all the work is lost. No layers. No way.
Paint.net is excellent and fast. The only weakness is that objects are blended into the image as soon as you hit Enter. So you need lots of layers and will have to redo each layer when you re-edit. Doable.
Inkspace does the job properly. Not trivial, and I am going to have trouble remembering how to get back to it (hence this post). But it has layers and keeps everything as Objects.
I’ll get better but here are the basics:
Start by importing an image. You can link or embed. Choose embed. Go to Document Properties and select “Resize to Content”.
Create a single bezier curve with an arrow. Create some text. Make sure they are the same color.
It is faster to copy and paste existing text and arrows than it is to get all the settings right over and over. If there is a way to make these values, I have yet to learn.
Once you copy and paste the new values, editing is weird.
a. For the Text, type the letter “T”. Then click on the text object. Then type new text.
b. For the arrow, type the key “F2”. That puts it into an edit mode where you can click and move the start and end points.
For assembling the document and building the html (or pdf), I am using asciidoctor. I could not get the Eclipse plugin to manage complex nested documents. VS Code or IntelliJ-Community works ok.
No one would recommend a serious parser that just iterated through an exhaustive list of possibilities. So I continued this obsessive, possessed, labor-of-love a little further. This is a hard problem.
Two big issues with DateTimeFormatter:
It is greedy.
There is no way to specify “one of many”
You can work around “greedy”. You cannot work around “one of many”. All you can do is provide “zero or more of many” and hope that greedy catches failures.
Also, this is an unsolvable problem in the sense that the solution will often be ambiguous. You’d never use this for “backend work”, obviously. And in the UI, you are relying on the user to check that the interpreted value is correct. That is unacceptable in some circles.
It might be acceptable to provide 3 results:
Correct value parsed with confidence. (Green)
A value was parsed but it might be wrong. (Orange)
A value could not be parsed. (Error/Red)
So I soldiered on. Creating a sequential list of optional patterns comes very close to working, but not quite. I ran into an obscure error where enough “[-]” patterns in sequence ate up the optional spaces and swallowed the “-” of the time zone offset “-05:30”.
Search google and you’ll see a suggestions to “nest the optionals” rather than just apply them sequentially. But that only works when you have a required constraint at the end of the chain. The problem for us is that our chain is all optional, so nested optionals have the same outcome as flattened optionals.
In the end, I solved the special cases by appending specific patterns to handle these errors. Ugly but necessary.
This is the best I have come up with so far. First a Builder to wrap a Builder:
package com.mri.util.time;
import java.time.LocalDate;
import java.time.format.DateTimeFormatter;
import java.time.format.DateTimeFormatterBuilder;
import java.time.temporal.ChronoField;
import java.time.temporal.TemporalField;
import java.util.Locale;
/**
* Criticism of DateTimeFormatterBuilder:
* 1) No way to declare oneOfMany.
* 2) Everything is greedy
*/
public class DateTimeFormatterBuilderBuilder {
final DateTimeFormatterBuilder builder;
final Locale locale;
public DateTimeFormatterBuilderBuilder() {
this(Locale.ENGLISH);
}
public DateTimeFormatterBuilderBuilder(Locale locale) {
this.locale = locale;
builder = new DateTimeFormatterBuilder().parseCaseInsensitive().parseStrict();
}
public DateTimeFormatter toFormatter() {
return builder.toFormatter(locale);
}
// #region separator
// This is still optional. No way to make this a requirement
// Make the space the last check. Otherwise will swallow " -", which catches the zone offsets
static final String separatorPattern = "[:][/][-][,][.][ ]";
static final DateTimeFormatter separatorOptional = DateTimeFormatter.ofPattern(separatorPattern);
public DateTimeFormatterBuilderBuilder appendOptionalSeparator() {
builder.appendOptional(separatorOptional); // could have also done builder.append(separatorOptional);
return this;
}
// #endregion
// #region optional descending from month to nano
/**
* year4 is required. everything following is optional
*/
public DateTimeFormatterBuilderBuilder year4MonthDayHourMinSecNanoTzOptional() {
year4();
appendOptionalSeparator();
monthDayHourMinSecNanoTzOptional();
defaultingAll();
return this;
}
/**
* year2 is required. everything following is optional
*/
public DateTimeFormatterBuilderBuilder year2SpaceMonthDayHourMinSecNanoTzOptional() {
year2();
appendOptionalSeparator();
monthDayHourMinSecNanoTzOptional();
defaultingAll();
return this;
}
public DateTimeFormatterBuilderBuilder year4() {
builder.appendValue(ChronoField.YEAR, 4); // this is exact
// builder.appendPattern("yyyy"); //this consumes 2 to 19 characters and is more flexible but can cause problems with neighbors
return this;
}
public DateTimeFormatterBuilderBuilder year2() {
builder.appendValueReduced(ChronoField.YEAR, 2, 2, LocalDate.of(1980, 1, 1)); // valid values from {@code 1980} to {@code 2079}
// builder.appendPattern("yy");
return this;
}
/**
* Still have an issue in this method. Turns out that the greedy year has fewer false parsing errors
* than specific widths. I don't know why and haven't investigated.
*/
public DateTimeFormatterBuilderBuilder yearAll() {
if (true) {
builder.appendPattern("[yyyy][yy]");
} else {
// This has a higher number of erroneous parsings
DateTimeFormatter year2 = new DateTimeFormatterBuilder().appendValue(ChronoField.YEAR, 4).toFormatter();
DateTimeFormatter year1 = new DateTimeFormatterBuilder().appendValue(ChronoField.YEAR, 2).toFormatter();
appendOneOf(year2, year1);
}
return this;
}
public DateTimeFormatterBuilderBuilder month2() {
builder.appendValue(ChronoField.MONTH_OF_YEAR, 2);
return this;
}
public DateTimeFormatterBuilderBuilder monthAll() {
appendPattern("[MMMM][MMM]"); // ChronoField not used for text inputs
DateTimeFormatter month2 = new DateTimeFormatterBuilder().appendValue(ChronoField.MONTH_OF_YEAR, 2).toFormatter();
DateTimeFormatter month1 = new DateTimeFormatterBuilder().appendValue(ChronoField.MONTH_OF_YEAR, 1).toFormatter();
return appendOneOf(month2, month1);
}
public DateTimeFormatterBuilderBuilder dayAll() {
DateTimeFormatter day2 = new DateTimeFormatterBuilder().appendValue(ChronoField.DAY_OF_MONTH, 2).toFormatter();
DateTimeFormatter day1 = new DateTimeFormatterBuilder().appendValue(ChronoField.DAY_OF_MONTH, 1).toFormatter();
return appendOneOf(day2, day1);
}
public DateTimeFormatterBuilderBuilder day2() {
builder.appendValue(ChronoField.DAY_OF_MONTH, 2);
return this;
}
public DateTimeFormatterBuilderBuilder hour2() {
builder.appendValue(ChronoField.HOUR_OF_DAY, 2);
return this;
}
public DateTimeFormatterBuilderBuilder minute2() {
builder.appendValue(ChronoField.MINUTE_OF_HOUR, 2);
return this;
}
public DateTimeFormatterBuilderBuilder second2() {
builder.appendValue(ChronoField.SECOND_OF_MINUTE, 2);
return this;
}
public DateTimeFormatterBuilderBuilder hourAll() {
DateTimeFormatter hour2 = new DateTimeFormatterBuilder().appendValue(ChronoField.HOUR_OF_DAY, 2).toFormatter();
DateTimeFormatter hour1 = new DateTimeFormatterBuilder().appendValue(ChronoField.HOUR_OF_DAY, 1).toFormatter();
return appendOneOf(hour2, hour1);
}
public DateTimeFormatterBuilderBuilder minuteAll() {
DateTimeFormatter minute2 = new DateTimeFormatterBuilder().appendValue(ChronoField.MINUTE_OF_HOUR, 2).toFormatter();
DateTimeFormatter minute1 = new DateTimeFormatterBuilder().appendValue(ChronoField.MINUTE_OF_HOUR, 1).toFormatter();
return appendOneOf(minute2, minute1);
}
public DateTimeFormatterBuilderBuilder secondAll() {
// this fails in the "MM dd yyy hh mm n tz" case ("05 12 1963 01 01 -05:30")
// problem is that greedy parsing in the optional separator swallows the space here, and the subsequent nano parsing
// swallows the minus sign of the time zone offset. And then the timezone parser fails because 05:30 is illegal (sign is required)
optionalStart();
DateTimeFormatter second2 = new DateTimeFormatterBuilderBuilder().appendValue(ChronoField.SECOND_OF_MINUTE, 2).toFormatter();
DateTimeFormatter second1 = new DateTimeFormatterBuilderBuilder().appendValue(ChronoField.SECOND_OF_MINUTE, 1).toFormatter();
appendOneOf(second2, second1);
optionalEnd();
return this;
}
public DateTimeFormatterBuilderBuilder secondAllX() {
optionalStart();
// moving the optional separator inside the required element so the position rolls back if not parsed.
// This eliminates the parsing errors (Exception because failed to parse) but greatly increases the parsed errors
// (parsed but incorrect value), because now the timezone offsets are parsed as nanoseconds.
DateTimeFormatter second2 = new DateTimeFormatterBuilderBuilder().appendOptionalSeparator().appendValue(ChronoField.SECOND_OF_MINUTE, 2).toFormatter();
DateTimeFormatter second1 = new DateTimeFormatterBuilderBuilder().appendOptionalSeparator().appendValue(ChronoField.SECOND_OF_MINUTE, 1).toFormatter();
appendOneOf(second2, second1);
optionalEnd();
return this;
}
/**
* The month-day-year version, with everything else being optional.
* If we use MM for the month, then there could be ambiguity with year-month-day.
* Could solve it by forcing a space after month. If so, consistency suggests spaces between month, day, and year, and hour.
* Or could just require a space after year. That is still a unique quirk, but is less visible/likely-problem
*/
public DateTimeFormatterBuilderBuilder monthDayYearHourMinSecNanoTzOptional() {
monthAll();
appendOptionalSeparator();
dayAll();
appendOptionalSeparator();
yearAll();
appendOptionalSeparator(); // to differentiate between year-month-day
hourMinSecNanoTzOptional();
defaultingAll();
return this;
}
/**
* The monthDayYearHourMinSecNanoTzOptional has one failure case:
* If there are no seconds, then it swallows the separator. The subsequent nano
* parser swallows the next separator, which includes the "-" of a ZoneOffset (e.g., -05:30).
* So the ZoneOffset parser fails on 05:30 because there is no sign.
* No known solution. So just add another backup case that skips the seconds and nanos
*
* BY THE WAY. THIS SHOWS ANOTHER ISSUE: IF THE USER SKIPS SECONDS BUT INCLUDES NANOSECONDS, WHO KNOWS WHAT WILL HAPPEN?
*/
public DateTimeFormatterBuilderBuilder monthDayYearHourMinTzOptional() {
monthAll();
appendOptionalSeparator();
dayAll();
appendOptionalSeparator();
yearAll();
appendOptionalSeparator(); // to differentiate between year-month-day
hourMinTzOptional();
defaultingAll();
return this;
}
public DateTimeFormatterBuilderBuilder year4MonthDayHourMinTzOptional() {
year4();
appendOptionalSeparator();
monthDayHourMinTzOptional();
defaultingAll();
return this;
}
private DateTimeFormatterBuilderBuilder monthDayHourMinSecNanoTzOptional() {
monthAll();
appendOptionalSeparator();
dayHourMinSecNanoTzOptional();
return this;
}
private DateTimeFormatterBuilderBuilder monthDayHourMinTzOptional() {
monthAll();
appendOptionalSeparator();
dayHourMinTzOptional();
return this;
}
private DateTimeFormatterBuilderBuilder dayHourMinSecNanoTzOptional() {
dayAll();
appendOptionalSeparator();
hourMinSecNanoTzOptional();
return this;
}
private DateTimeFormatterBuilderBuilder dayHourMinTzOptional() {
dayAll();
appendOptionalSeparator();
hourMinTzOptional();
return this;
}
private DateTimeFormatterBuilderBuilder hourMinSecNanoTzOptional() {
hourAll();
appendOptionalSeparator();
minuteAll();
appendOptionalSeparator();
secondAll();
appendOptionalSeparator();
appendPattern("[n]");
appendAllTimeZones();
return this;
}
private DateTimeFormatterBuilderBuilder hourMinTzOptional() {
hourAll();
appendOptionalSeparator();
minuteAll();
appendAllTimeZones();
return this;
}
public DateTimeFormatterBuilderBuilder yyyymmddOptional() {
year4();
month2();
day2();
appendOptionalSeparator();
hourMinSecNanoTzOptional();
return this;
}
public DateTimeFormatterBuilderBuilder mmddyyyyOptional() {
month2();
day2();
year4();
appendOptionalSeparator();
hourMinSecNanoTzOptional();
return this;
}
// #endregion
// #region timezones
// Need a separator before the timezone. Cannot include '-' because that swallows the "minus". Just use a space
// Make it optional because everything in this series is optional
private static final String allTimeZonesWithSpacePrefixStr = "[ ][VV][xxxx][XXX][z][zzzz]";
static final DateTimeFormatter allTimeZonesWithSpacePrefixEnglish = DateTimeFormatter.ofPattern(allTimeZonesWithSpacePrefixStr, Locale.ENGLISH);
// Tried to improve the previous line but could not. This produces worse results. Still investigating...
// private static final DateTimeFormatter allTimeZonesWithSpacePrefix = allTimeZonesInferior(Locale.ENGLISH);
// static DateTimeFormatter allTimeZonesInferior(Locale locale) {
// DateTimeFormatterBuilder builder = new DateTimeFormatterBuilder();
// builder.appendPattern("[ ]");
// builder.optionalStart().appendZoneOrOffsetId().optionalEnd();
// builder.optionalStart().appendLocalizedOffset(TextStyle.FULL).optionalEnd();
// builder.optionalStart().appendLocalizedOffset(TextStyle.SHORT).optionalEnd();
// for (TextStyle textStyle : TextStyle.values()) {
// builder.optionalStart().appendZoneText(textStyle).optionalEnd();
// }
// return builder.toFormatter(locale);
// }
/**
* Include one of all four timezone formats
*
* Symbol Meaning Example
* VV Full Time Zone ID America/Chicago, Asia/Tokyo
* z Short Zone Name CST, PST, GMT
* Z Offset without colons +0530, -0800
* XXX Offset with colons +05:30, -08:00
*
* VV (Zone ID): Parses regional IDs like Europe/Paris or America/New_York.
* x (Zone Offset): Parses formats like +05 or +0530 (outputs +00 for zero).
* XX (Zone Offset): Parses formats like +0530 or Z (outputs Z for zero).
* XXX (Zone Offset with Colon): Parses standard formats like +05:30 or Z.
* z (Short Zone Name): Parses abbreviations like EST, PST, or GMT
* zzzz (Long Zone Name): Parses full names like Pacific Standard Time
*/
public DateTimeFormatterBuilderBuilder appendAllTimeZones() {
// requiredSpace(); //Cannot be a separator because it swallows the "minus"
// used cache value when possible
if (locale == Locale.ENGLISH) {
return append(allTimeZonesWithSpacePrefixEnglish);
} else {
return append(DateTimeFormatter.ofPattern(allTimeZonesWithSpacePrefixStr, locale));
}
}
// #endregion
public DateTimeFormatterBuilderBuilder defaultingAll() {
builder.parseDefaulting(ChronoField.MONTH_OF_YEAR, 1);
builder.parseDefaulting(ChronoField.DAY_OF_MONTH, 1);
builder.parseDefaulting(ChronoField.HOUR_OF_DAY, 0);
builder.parseDefaulting(ChronoField.MINUTE_OF_HOUR, 0);
builder.parseDefaulting(ChronoField.SECOND_OF_MINUTE, 0);
builder.parseDefaulting(ChronoField.NANO_OF_SECOND, 0);
return this;
}
public DateTimeFormatterBuilderBuilder requiredSpace() {
builder.appendLiteral(' ');
return this;
}
public DateTimeFormatterBuilderBuilder append(DateTimeFormatter formatter) {
builder.append(formatter);
return this;
}
private DateTimeFormatterBuilderBuilder optionalStart() {
builder.optionalStart();
return this;
}
private DateTimeFormatterBuilderBuilder optionalEnd() {
builder.optionalEnd();
return this;
}
public DateTimeFormatterBuilderBuilder appendOptional(DateTimeFormatter formatter) {
builder.appendOptional(formatter);
return this;
}
public DateTimeFormatterBuilderBuilder appendPattern(String str) {
builder.appendPattern(str);
return this;
}
public DateTimeFormatterBuilderBuilder appendOptionalPatterns(String... patterns) {
optionalStart();
for (String pattern : patterns) {
optionalStart();
appendPattern(pattern);
optionalEnd();
}
optionalEnd();
return this;
}
public DateTimeFormatterBuilderBuilder appendLiteral(String str) {
builder.appendLiteral(str);
return this;
}
public DateTimeFormatterBuilderBuilder appendValue(TemporalField field, int width) {
builder.appendValue(field, width);
return this;
}
// warning: there is no way to specify that one of them MUST be required
// just append them all sequentially as optional
public DateTimeFormatterBuilderBuilder appendOneOf(DateTimeFormatter... formatters) {
for (DateTimeFormatter formatter : formatters) {
appendOptional(formatter);
}
return this;
}
}
And obligatory global utility classes:
public final class MriUtilsLocalDate {
package com.mri.util.time;
import java.time.LocalDate;
import java.time.format.DateTimeFormatter;
import java.util.ArrayList;
import java.util.List;
//package visible
final class MriUtilsLocalDate {
public static final DateTimeFormatter ISO_DATE_FORMATTER = DateTimeFormatter.ISO_DATE; // ISO-8601
public static final String ISO_DATE = "yyyy-MM-dd"; // corresponds ISO_DATE_FORMATTER
static {
MriUtilsTime.formatterMap.put(ISO_DATE, ISO_DATE_FORMATTER);
}
// make sure this comes AFTER the statics
public static final MriUtilsLocalDate INSTANCE = new MriUtilsLocalDate();
/**
* A list of DateTimeFormatters that are used in sequence to attempt to parse a String as a LocalDate
*/
final List
<DateTimeFormatter> sequencedFormatters;
private MriUtilsLocalDate() {
sequencedFormatters = new ArrayList<>();
sequencedFormatters.add(ISO_DATE_FORMATTER);
sequencedFormatters.add(new DateTimeFormatterBuilderBuilder().yyyymmddOptional().toFormatter());
sequencedFormatters.add(new DateTimeFormatterBuilderBuilder().mmddyyyyOptional().toFormatter());
sequencedFormatters.add(new DateTimeFormatterBuilderBuilder().year4MonthDayHourMinSecNanoTzOptional().toFormatter());
sequencedFormatters.add(new DateTimeFormatterBuilderBuilder().year2SpaceMonthDayHourMinSecNanoTzOptional().toFormatter());
sequencedFormatters.add(new DateTimeFormatterBuilderBuilder().monthDayYearHourMinSecNanoTzOptional().toFormatter());
//all these other cases to catch perverse issues with minus signs in ZoneOffset and the greedy "-" separator
sequencedFormatters.add(new DateTimeFormatterBuilderBuilder().monthDayYearHourMinTzOptional().toFormatter());
sequencedFormatters.add(new DateTimeFormatterBuilderBuilder().year4MonthDayHourMinTzOptional().toFormatter());
}
/**
* Expect this to be typed in by a user who will inspect the results.
* So do our best to find a result, but there is a possibility it will be wrong
*/
LocalDate parseFlexibleLocalDate(CharSequence text) {
return MriUtilsTimePriv.parseFormatterSequence(sequencedFormatters, text, LocalDate::from);
}
}
package com.mri.util.time;
import java.time.LocalDateTime;
import java.time.format.DateTimeFormatter;
import java.util.ArrayList;
import java.util.List;
//package visible
final class MriUtilsLocalDateTime {
public static final DateTimeFormatter ISO_LOCAL_DATE_TIME_FORMATTER = DateTimeFormatter.ISO_LOCAL_DATE_TIME;
public static final String ISO_LOCAL_DATE_TIME = "yyyy-MM-dd'T'HH:mm:ss";
static {
MriUtilsTime.formatterMap.put(ISO_LOCAL_DATE_TIME, ISO_LOCAL_DATE_TIME_FORMATTER);
}
// this no longer works because the yyyy is greedy. Have to use ChronoField4 instead
// public static final String YYYYMMDDHH = MriUtilsLocalDate.YYYYMMDD+"HH";
// make sure this comes AFTER the statics
public static final MriUtilsLocalDateTime INSTANCE = new MriUtilsLocalDateTime();
/**
* A large list of DateTimeFormatters that are used in sequence to attempt to parse a String as a LocalDate
*/
final List
<DateTimeFormatter> sequencedFormatters;
private MriUtilsLocalDateTime() {
sequencedFormatters = new ArrayList<>();
sequencedFormatters.add(ISO_LOCAL_DATE_TIME_FORMATTER);
sequencedFormatters.addAll(MriUtilsLocalDate.INSTANCE.sequencedFormatters);
}
/**
* Expect this to be typed in by a user who will inspect the results.
* So do our best to find a result, but there is a possibility it will be wrong
*/
LocalDateTime parseFlexibleLocalDateTime(CharSequence text) {
return MriUtilsTimePriv.parseFormatterSequence(sequencedFormatters, text, LocalDateTime::from);
}
}
package com.mri.util.time;
import java.time.Instant;
import java.time.format.DateTimeFormatter;
import java.time.format.DateTimeFormatterBuilder;
import java.time.temporal.ChronoField;
import java.time.temporal.TemporalAccessor;
import java.util.ArrayList;
import java.util.List;
import java.util.TimeZone;
import org.jspecify.annotations.Nullable;
//package visible
final class MriUtilsInstant {
// ISO-8601 '2011-12-03T10:15:30Z'
public static final DateTimeFormatter ISO_INSTANT = DateTimeFormatter.ISO_INSTANT;
// Standard iso format for zoneddatetime/instant parsing. user includes timezone
public static final String MM_DD_YYYY_HH_MM_SS_NANO_ZONE = "MM/dd/yyyy HH:mm:ss.n'['VV']'";
public static final DateTimeFormatter MM_DD_YYYY_HH_MM_SS_NANO_ZONE_FORMATTER = new DateTimeFormatterBuilder()
.appendPattern("MM/dd/yyyy HH:mm:ss")
.appendFraction(ChronoField.NANO_OF_SECOND, 0, 9, true)
.appendLiteral(' ')
.appendZoneId()
.toFormatter();
// make sure this goes after the statics
public static final MriUtilsInstant INSTANCE = new MriUtilsInstant();
/**
* A large list of DateTimeFormatters that are used in sequence to attempt to parse a String as a LocalDate
*/
private final List
<DateTimeFormatter> sequencedFormatters;
private MriUtilsInstant() {
sequencedFormatters = new ArrayList<>();
sequencedFormatters.add(ISO_INSTANT);
sequencedFormatters.add(MM_DD_YYYY_HH_MM_SS_NANO_ZONE_FORMATTER);
sequencedFormatters.addAll(MriUtilsLocalDateTime.INSTANCE.sequencedFormatters);
}
/**
* Expect this to be typed in by a user who will inspect the results.
* So do our best to find a result, but there is a possibility it will be wrong.
* Not all formats require a TimeZone, as sometimes the TZ will be in the String.
*/
public Instant parseFlexibleInstant(CharSequence text, @Nullable TimeZone defaultTimeZone) {
TemporalAccessor temporal = MriUtilsTimePriv.parseFormatterSequenceBest(sequencedFormatters, text);
return MriUtilsTime.instantFromTemporal(temporal, defaultTimeZone);
}
}
public static @Nullable Instant instantFromTemporal(@Nullable TemporalAccessor temporal, @Nullable TimeZone defaultTimeZone) {
return switch (temporal) {
case Instant inst -> inst;
case ZonedDateTime zoned -> zoned.toInstant();
case LocalDateTime local -> localDateTimeToInstant(local, defaultTimeZone);
case LocalDate localDate -> localDateTimeToInstant(localDate.atStartOfDay(), defaultTimeZone);
case LocalTime localTime -> localDateTimeToInstant(localTime.atDate(LocalDate.now()), defaultTimeZone);
case null -> null;
default -> throw new IllegalArgumentException("Unexpected class= " + temporal.getClass() + " value: " + temporal);
};
}
public static @Nullable Instant localDateTimeToInstant(@Nullable LocalDateTime localDateTime, @Nullable TimeZone tz) {
if (localDateTime == null || tz == null) {
return null;
}
return localDateTime.atZone(tz.toZoneId()).toInstant();
}
}
class MriUtilsTimePriv {
private static Logger LOG = org.apache.logging.log4j.LogManager.getLogger(MriUtilsTimePriv.class);
public static TemporalAccessor parseFormatterSequenceBest(List
<DateTimeFormatter> formatters, CharSequence text, TemporalQuery<?>... queries) {
for (DateTimeFormatter formatter : formatters) {
try {
return formatter.parseBest(text, queries);
} catch (DateTimeParseException ignore) {
// noop
LOG.trace("ignore: text={} formatter={}", text, formatter, ignore);
} catch (Exception e) {
LOG.warn("Ignoring exception text={} formatter={} ex={}", text, formatter, e);
}
}
throw MriException.from("Could not parse temporal = " + text);
}
public static TemporalAccessor parseFormatterSequenceBest(List
<DateTimeFormatter> formatters, CharSequence text) {
return parseFormatterSequenceBest(formatters, text, Instant::from, LocalDateTime::from, LocalDate::from, LocalTime::from);
}
public static
<T> T parseFormatterSequence(List<DateTimeFormatter> formatters, CharSequence text, TemporalQuery<T> query) {
for (DateTimeFormatter formatter : formatters) {
try {
return formatter.parse(text, query);
} catch (DateTimeParseException ignore) {
// noop
LOG.trace("ignore: text={} formatter={}", text, formatter, ignore);
} catch (Exception e) {
LOG.warn("Ignoring exception text={} formatter={}", text, formatter);
}
}
throw MriException.from("Could not parse temporal = " + text);
}
}
I’m not going to show the JUnit test classes because of the amount of code. (And this doesn’t dseserve its own github repository.) However, I am pleased with the results so far. Currently with a few thousand tests (can easily add many thousands more), no parse failures, and the only errors are caused by greedy/ambiguous parsing, which I don’t think I can fix.
I want a date/time/instant parser that “just works” for anything the user is typing in. An AI-solution that analyzed a sentence and did its best would be great, but I am not ready for that amount of work. I could write my own custom antrl parser. But really, the DataTimeFormatter should do the job.
One solution is to create a list of DataTimeFormatters and just try them one at a time. This has some inefficiency.
But DataTimeFormatter has something just for that: The .appendOptional method.
The quickest way for an expert user to type a date is without punctuation. For example, “5 12 26” (using month day year format), Or even shorter: “20260512”. I use the latter a lot because it sorts nicely.
But we also want to handle punctuation between values. A space, a comma, a dash, or a slash. It would be great if DataTimeFormatter had an appendLiteral(“[ ,-/]”) (borrowing regex notation), but it does not. It can support that, but you have to work with .optionalStart and .optionalEnd, which is a little more complicated. Still doable, though.
I have some basic cartesianProduct code, so I wrote it longhand. This is what I came up with:
/**
* A large list of DateTimeFormatters that are used in sequence to attempt to parse a String
*/
private static final List
<DateTimeFormatter> sequencedLocalDateFormatters;
public static final DateTimeFormatter TRY_ALL_LOCAL_DATE_FORMATTER;
static {
sequencedLocalDateFormatters = new ArrayList<>();
sequencedLocalDateFormatters.add(ISO_DATE_FORMATTER);
sequencedLocalDateFormatters.add(formatter(YYYYMMDD));
List
<Object> years = List.of("yyyy", "yy");
List
<Object> months = List.of("MMMM", "MMM", "MM");
List
<Object> days = List.of("dd");
List
<Object> separators = List.of(" ", "-", "/", ",");
List<List<Object>> sets = List.of(years, months, days, separators);
List<List<Object>> cartesian = cartesianProduct(sets);
for (List
<Object> list : cartesian) {
String year = (String) list.get(0);
String month = (String) list.get(1);
String day = (String) list.get(2);
String sep = (String) list.get(3);
sequencedLocalDateFormatters.add(DateTimeFormatter.ofPattern(year + sep + month + sep + day));
sequencedLocalDateFormatters.add(DateTimeFormatter.ofPattern(month + sep + day + sep + year));
}
DateTimeFormatterBuilder tryAllFormatter = new DateTimeFormatterBuilder();
for (DateTimeFormatter dateTimeFormatter : sequencedLocalDateFormatters) {
tryAllFormatter = tryAllFormatter.appendOptional(dateTimeFormatter);
}
TRY_ALL_LOCAL_DATE_FORMATTER = tryAllFormatter.toFormatter();
}
public static LocalDate parseLocalDate(CharSequence text) {
return LocalDate.parse(text, TRY_ALL_LOCAL_DATE_FORMATTER);
}
/**
* Cartesian product
* https://www.baeldung.com/java-cartesian-product-sets
*/
static
<T> List<List<Object>> cartesianProduct(List<List<Object>> sets) {
return cartesianProduct(sets,0).collect(Collectors.toList());
}
static Stream<List<Object>> cartesianProduct(List<List<Object>> sets, int index) {
if (index == sets.size()) {
List
<Object> emptyList = new ArrayList<>();
return Stream.of(emptyList);
}
List
<Object> currentSet = sets.get(index);
return currentSet.stream().flatMap(element -> cartesianProduct(sets, index+1)
.map(list -> {
List
<Object> newList = new ArrayList<>(list);
newList.add(0, element);
return newList;
}));
}
//JUnit tests
private static Stream
<Arguments> localDateData() {
return Stream.of(
Arguments.of("05 12 1963", LocalDate.of(1963, 5, 12)),
Arguments.of("05-12-1963", LocalDate.of(1963, 5, 12)),
Arguments.of("05/12/1963", LocalDate.of(1963, 5, 12)),
Arguments.of("May 12 1963", LocalDate.of(1963, 5, 12)),
Arguments.of("August 12 1963", LocalDate.of(1963, 8, 12)),
Arguments.of("05 12 63", LocalDate.of(2063, 5, 12)),
Arguments.of("05-12-63", LocalDate.of(2063, 5, 12)),
Arguments.of("05/12/63", LocalDate.of(2063, 5, 12)),
Arguments.of("May 12 63", LocalDate.of(2063, 5, 12)),
Arguments.of("August 12 63", LocalDate.of(2063, 8, 12)),
Arguments.of("19630512", LocalDate.of(1963, 5, 12)),
Arguments.of("1963-05-12", LocalDate.of(1963, 5, 12)),
Arguments.of("1963/05/12", LocalDate.of(1963, 5, 12)));
}
@ParameterizedTest
@MethodSource("localDateData")
void test1(String str, LocalDate expectedDate) {
LocalDate date = LocalDate.parse.(str, TRY_ALL_LOCAL_DATE_FORMATTER);
assertThat(date).isEqualTo(expectedDate);
}
But when I ran the unit tests, there were errors:
It should have worked. Here is the gemini suggestion for testing the case that errored.
@Test
// gemini suggestion
void geminiSuggestion() {
String dateString = "05 12 63";
// Use MM for month, dd for day, and yy for 2-digit year
DateTimeFormatter formatter = DateTimeFormatter.ofPattern("MM dd yy");
LocalDate date = LocalDate.parse(dateString, formatter);
System.out.println(date); // Outputs: 2063-05-12
}
And I am certain that “MM dd yy” is in the list.
Seems like a java bug to me. If I give the DateTimeFormatter a list of DateTimeFormatters to try, it should recover from an individual error and try them all.
So I switched to the “long-hand” version:
public static LocalDate parseLocalDate(CharSequence text) {
//return LocalDate.parse(text, TRY_ALL_LOCAL_DATE_FORMATTER);
for (DateTimeFormatter dateTimeFormatter : sequencedLocalDateFormatters) {
try {
return LocalDate.parse(text, dateTimeFormatter);
} catch (Exception ignore) {}
}
throw new RuntimeException.from("Could not parse LocalDate = ", text);
}
This article discusses the limitations and hassles of java generics when dealing with “parallel class hierarchies”. A parallel class hierarchy is the situation where you have a “main” class hierarchy and a “secondary” class hierarchy that mirrors the “main” hierarchy. The secondary class models some (isolatable/groupable) aspect of the main class that can and should be separated into another class. This frequently shows up in classical object or relational data models.
To get concrete, let’s start with two main classes: Equipment and Structure. Equipment is generally mobile, whereas Structure is not. Both are subclasses of a common abstract class PhysicalItem. The class diagram and java classes are shown below. Fields are omitted.
public abstract static class PhysicalItem {}
public static class Equipment extends PhysicalItem {}
public static class Structure extends PhysicalItem {}
Now let’s add a “Status” attribute to this hierarchy. A Status is a collection of properties that changes tofether (and frequently), thus we wish to put them into a separate class, rather than the main class.
public abstract static class PhysicalItem {}
public static class Equipment extends PhysicalItem {}
public static class Structure extends PhysicalItem {}
public abstract static class PhysicalItemStatus {}
public static class EquipmentStatus extends PhysicalItemStatus {}
public static class StructureStatus extends PhysicalItemStatus {}
The data modellers draw an arrow (directional or bidirectional) between the PhysicalItem and PhysicalItemStatus, note the need for the subclasses to handle the appropriate class casting, and consider themselves done.
The programmers have multiple ways to implement that arrow. They can add a field named “status” to the PhysicalItem of type PhysicalItemStatus. And/or they can add a field “item” to the PhysicalItemStatus of type PhysicalItem. Those fields can be in the superclass or in the subclasses. Another option is to create a 3rd class to hold the two fields “status” and “item”, but that is hardly ever done.
For the point of this article, we’re going to choose the first option: Add a field named “status” to the PhysicalItem of type PhysicalItemStatus. So we add getter methods to the PhysicalItem class hierarchy:
public abstract static class PhysicalItem {
protected PhysicalItemStatus status;
public PhysicalItemStatus getStatus() {
return status;
}
}
public static class Equipment extends PhysicalItem {
@Override public EquipmentStatus getStatus() {
return (EquipmentStatus) status;
}
}
public static class Structure extends PhysicalItem {
@Override public StructureStatus getStatus() {
return (StructureStatus) status;
}
}
Everything is perfect. Notice how our IDE (integration development environment) is aware of the method overrides and automatically knows the correct type.
We can add setter methods to the subclass but they cannot OVERRIDE the parent setter method. So client code sees BOTH methods. It is STILL possible to cause a runtime error.
public abstract static class PhysicalItem {
protected PhysicalItemStatus status;
public void setStatus(PhysicalItemStatus status) {
this.status = status;
}
}
public static class Equipment extends PhysicalItem {
public void setStatus(EquipmentStatus status) {
this.status = status;
}
}
public static class Structure extends PhysicalItem {
public void setStatus(StructureStatus status) {
this.status = status;
}
}
The image below is the eclipse IDE showing the suggestions to complete the setter method. the problem is that we see TWO methods. One is right and the other leads to runtime errors.
Before java gained “generics” we had to live with this. The code had to be written defensively to throw errors when the wrong method was called. And the multiple method problem was so annoying we usually just lived with the single method in the superclass.
When java generics arrived, we could convert our Status class into a generic. Then we could declare our getter and setter in the superclass using the generic variable. Our subclasses now require the correct argument types and can show errors at COMPILE TIME.
public abstract static class PhysicalItem<STATUS extends PhysicalItemStatus> {
protected STATUS status;
public STATUS getStatus() {
return status;
}
public void setStatus(STATUS status) {
this.status = status;
}
}
public static class Equipment extends PhysicalItem
<EquipmentStatus> {}
public static class Structure extends PhysicalItem
<StructureStatus> {}
public static void getterCastingIsAutomatic(PhysicalItem item, Equipment equipment, Structure structure) {
PhysicalItemStatus itemStatus = item.getStatus();
EquipmentStatus equipmentStatus = equipment.getStatus();
StructureStatus structureStatus = structure.getStatus();
}
public static void noProblemsWithSubclassSetters(Equipment equipment, Structure structure,
PhysicalItemStatus itemStatus, EquipmentStatus equipmentStatus, StructureStatus structureStatus) {
equipment.setStatus(equipmentStatus); //fine
structure.setStatus(structureStatus); //fine
equipment.setStatus(structureStatus); //WRONG TYPE. COMPILER ERROR
equipment.setStatus(itemStatus); //WRONG TYPE. COMPILER ERROR
structure.setStatus(equipmentStatus); //WRONG TYPE. COMPILER ERROR
structure.setStatus(itemStatus); //WRONG TYPE. COMPILER ERROR
}
public static void potentialErrorsWithSuperclassSetters(PhysicalItem item, PhysicalItemStatus itemStatus, EquipmentStatus equipmentStatus, StructureStatus structureStatus) {
item.setStatus(itemStatus); //LEGAL BUT POTENTIAL RUNTIME ERROR
item.setStatus(equipmentStatus); //LEGAL BUT POTENTIAL RUNTIME ERROR
item.setStatus(structureStatus); //LEGAL BUT POTENTIAL RUNTIME ERROR
}
For those who complain about CSS in HTML pages, the oldtime joke: “CSS is the worst thing ever! With the exception of not having CSS.” Well, the same thing applies to generics. “Generics is the worst thing ever, except for not having generics.”
(Well-read readers will have immediately noted that I am stealing the phrase from Winston Churchill: “Many forms of Government have been tried, and will be tried in this world of sin and woe. No one pretends that democracy is perfect or all-wise. Indeed it has been said that democracy is the worst form of Government except all those other forms that have been tried from time to time”.)
There isn’t a solution to using generics in this manner. They do not provide a 100% solution.
Perhaps even worse than not solving the problem, generics spread to all client code. Now ALL clients of the hierarchy must deal with generics, even if that particular code has nothing to do with status. Either you write your code to ignore generics (and ignore the compiler warnings), or you add <?> everywhere pointlessly. It is a REAL burden.
And it is a burden that multiplies. Because big data models have many aspects that we’d like to extract into secondary classes. So there is a code tug towards many generics, and we wind up referring to PhysicalItem<? extends PhysicalItemStatus, ? extends PhysicalItemHistory, ? extends PhysicalItemType, ? extends CivilOrMilitary> and more. Every time you add a new generic, you break code in potentially hundreds of places.
To be clear, java generics “disappear at the leaf classes”, i.e., those classes that have no subclasses. (If Equipment was a concrete subclass, code dealing with Equipment would have no generics.) However, much of our code will be required to reference intermediate classes (classes which have superclasses and subclasses), and that is where the pain is. Equipment has many subclasses but a lot of code just needs to know it is an Equipment. Hence, generics-hell.
After many years of fighting this, I have come to believe that the price of generics is too high to include them in our “main” classes. Generics are very useful, but they MUST be contained within the code that needs them, while all other code must be able to work without knowing about them.
My solution is a “bridge” method that converts the main class to a particular generic instance. This method takes the client from the main instance (that has no generics) to the generic secondary instance (that DOES have the generics).
In our example, there is no getter and setter for the status field on PhysicalItem. Instead, a new method toPhysicalItemStatus() returns a PhysicalItem “bridge” instance which DOES have generics.
The following is a complete example:
public abstract class PhysicalItem{
protected PhysicalItemStatus status;
/**
* Delegate to a "Bridge" class that "casts" to an instance with the correct generics.
*/
public HasPhysicalItemStatus<? extends PhysicalItemStatus> toPhysicalItemStatus() {
return new HasPhysicalItemStatusBridge<>(this, PhysicalItemStatus.class);
}
}
public class Equipment extends PhysicalItem {
@Override public HasPhysicalItemStatus
<EquipmentStatus> toPhysicalItemStatus() {
return new HasPhysicalItemStatusBridge<>(this, EquipmentStatus.class);
}
}
public class Structure extends PhysicalItem {
@Override public HasPhysicalItemStatus
<StructureStatus> toPhysicalItemStatus() {
return new HasPhysicalItemStatusBridge<>(this, StructureStatus.class);
}
}
public interface HasPhysicalItemStatus<STATUS extends PhysicalItemStatus>{
STATUS getStatus();
void setStatus(STATUS status);
}
/**
* A "bridge" instance that switches to Status with the correct generics.
* This is a new instance, so theoretically it requires heap space. However, everything is final, so
* short-lived instances will not incur instance allocation and garb age collection.
*
* Put this in the same package as the PhysicalItem so it can access a private/protected field (status).
* Alternatively, can live in a different package, and the constructor needs to provide a getter and setter
*/
public final class HasPhysicalItemStatusBridge<STATUS extends PhysicalItemStatus> implements HasPhysicalItemStatus<STATUS>{
private final PhysicalItem item;
private final Class
<STATUS> statusClass;
public HasPhysicalItemStatusBridge(PhysicalItem item, Class
<STATUS> statusClass) {
this.statusClass = statusClass;
this.item = item;
}
@SuppressWarnings("unchecked") @Override public STATUS getStatus() {
return (STATUS) item.status;
}
@Override public void setStatus(STATUS newStatus) {
assert statusClass.isInstance(newStatus); //intermediate classes need checking
item.status = newStatus;
}
}
public abstract class PhysicalItemStatus {}
public class EquipmentStatus extends PhysicalItemStatus {}
public class StructureStatus extends PhysicalItemStatus {}
The test code below shows the results of all the getters and setters. Subclasses have correct typing. Intermediate classes have “as correct as can be” methods but will always require some amount of runtime type checking. The possibility of runtime errors exist, but no worse than before. We catch them at runtime and throw an Exception rather than corrupting the data model.
public static void testExamples(PhysicalItem item, Equipment equipment, Structure structure,
PhysicalItemStatus itemStatus, EquipmentStatus equipmentStatus, StructureStatus structureStatus) {
//Correctly typed
HasPhysicalItemStatus<? extends PhysicalItemStatus> physicalItemBridge = item.toPhysicalItemStatus();
HasPhysicalItemStatus
<EquipmentStatus> equipmentBridge = equipment.toPhysicalItemStatus();
HasPhysicalItemStatus
<StructureStatus> structureBridge = structure.toPhysicalItemStatus();
//Correctly typed
PhysicalItemStatus status1 = physicalItemBridge.getStatus();
EquipmentStatus status2 = equipmentBridge.getStatus();
StructureStatus status3 = structureBridge.getStatus();
//supertype has issues. (But always will)
physicalItemBridge.setStatus(itemStatus); //COMPILE ERROR because the type is <? extends PhysicalItemStatus> instead of <PhysicalItemStatus>
//supertype "solution" to the above error also has issues
HasPhysicalItemStatus
<PhysicalItemStatus> physicalItemStatusBridge2 = (HasPhysicalItemStatus<PhysicalItemStatus>) item.toPhysicalItemStatus(); //have to cast
physicalItemStatusBridge2.setStatus(itemStatus); //This is now legal but a possible runtime error, so it needs runtime checking
physicalItemBridge.setStatus(equipmentStatus); //COMPILE ERROR CORRECTLY
physicalItemBridge.setStatus(structureStatus); //COMPILE ERROR CORRECTLY
equipmentBridge.setStatus(itemStatus); //COMPILE ERROR CORRECTLY
equipmentBridge.setStatus(equipmentStatus); //fine
equipmentBridge.setStatus(structureStatus); //COMPILE ERROR CORRECTLY
structureBridge.setStatus(itemStatus); //COMPILE ERROR CORRECTLY
structureBridge.setStatus(equipmentStatus); //COMPILE ERROR CORRECTLY
structureBridge.setStatus(structureStatus); //fine
}
The important point is that:
The main classes are declared free of generics. So we don’t degrade the overall code base.
Generics ARE provided for code that can benefit from it. The cost is one extra method that delegates/bridges to an intermediate generically-typed interface..
A while back, spring started supporting yaml files as well as properties files for its configuration. Newer things sounded good so I switched to it.
My experience has been awful. Silent failures that don’t show errors and lead me down wild goose chases.
The problem is that yaml files are white-space sensitive. Indentation matters. And the indentation must be consistent: I you use 2-spaces somewhere and 3-spaces somewhere else, the indentation will not work and the parser will silently ignore the properties.
I must have had 20 of these errors. Sometimes I caught it quickly. Other times I spent an hour looking for the problem in code that wasn’t there. I’ve had enough. Back to boring properties files.
Note that we will often find yaml code on the internet that we want to use. For that, pick one of the yaml-to-properties online web pages.
Here is my last error that was the final straw:
The following is incorrect! Run this code and spring will throw a fatal error that it could not find the Datasource
spring:
application:
name: jsonstore-server
main:
banner-mode: OFF
datasource:
url: jdbc:postgresql://${postgres.url:localhost:5432/jsonstore}
This is correct! Can you spot the difference?
spring:
application:
name: jsonstore-server
main:
banner-mode: OFF
datasource:
url: jdbc:postgresql://${postgres.url:localhost:5432/jsonstore}
Playwright and Selenium are the two big choices when choosing a browser user-interface test programming tool. Selenium has been around a long time. Playwright is the new kid in town.
I’ve used Selenium before. It is a pita but it mostly works. Unfortunately, even 99% “mostly works” is a problem when you are running hundreds of tests. That means something is always failing. So you wind up writing all your code with “wait-until-something-is true” and “try-this-multiple-times-until-it-succeeds” features. And then it still fails once in a while, so you just have to repeat the whole test and then it works. The bigger the project, the worse this problem becomes.
In short, we use Selenium because we have to, not because we like it.
I had the opportunity to start a new project so I tried Playwright. Still a learning curve. Still requires a lot of work. But they took all the “wait-until” stuff and moved it “behind the scenes”. It still has to be done, but you, the programmer, don’t have to handle it yourself. unless you want to. Much better.
After 2 weeks working with Playwright, I was still impressed. Progress was slow but steady.ย The hardest part was that I am using Vaadin as the front-end development tool and they make serious use of the shadow DOM, so each new element type took trial and error to get working. This would have been the same amount of work in Playwright and Selenium.
I was also fighting against the “best-practices” of Playwright. I like to use “id” attributes whenever I am selecting something. And I really like to use XPath. Yes, XPath can be brittle, but don’t kid yourself: UI testing is always going to be brittle. Now, Playwright doesn’t support XPath inside the shadow-dom, and I was constantly running into that problem. Eventually, everything I was doing with XPath was easily handled using CSS. For example, select the element with type “vaadin-form-layout” and attributes class=”user=prefs” and id=”userPrefsId”. So I was writing “xpath-ish” and it was easily translated into CSS “vaadin-form-layout[user=”prefs”][id=userPrefsId”]” and so forth. Anyway, personal preferences and nothing to do with the subject of Playwright vs Selenium.
His arguments were reasonable but not sufficiently detailed to be definitively persuasive. To summarize at a very high level, the best arguments were:
Playwright did waiting wrong.
Selenium is the web-standard and google/facebook will make sure it is up to date. Playwright could get left behind.
Ok, both of these are serious accusations. And I don’t feel qualified to comment on their validity.
Emotionally, the author, Zhimin Zhan seemed a bit cranky. Certainly seems like an expert, but sometimes experts get cranky when their favorite technology gets left behind. Either possibility seemed plausible.
So I decided I would redo the last 2 weeks work in Playwright in Selenium.ย It only took a few hours.
As soon as I ran the same tests in Selenium, I remembered why it was always so frustrating:
The first problem was with the Save-Menu. On startup it is inactive (disabled=”true”) and my tests assert that. However, the Selenium method isEnabled() returned true. Google “selenium isenabled not working”. My God! How many years now and that is STILL broken?
We shouldn’t all have to write this crappy code:
public static boolean isEnabled(WebElement element) { boolean enabled1 = element.isEnabled(); //this can be wrong String disabled = element.getAttribute("disabled"); //this is reliable boolean disabled2 = disabled != null && Boolean.parseBoolean(disabled); if (enabled1 == disabled2) { System.err.println("discrepancy in isEnabled"); enabled1 = !disabled2; } return enabled1; }
The next problem was when I clicked on a VaadinSideNavItem. I got this error:
org.openqa.selenium.ElementClickInterceptedException: element click intercepted: Element <vaadin-side-nav-item path="domain/person" id="CometPersonInit-peopleNav" role="listitem" has-children="">...</vaadin-side-nav-item> is not clickable at point (127, 92). Other element would receive the click: <html lang="en" theme="dark">...</html>
The ‘theme=”dark”‘ element is adjacent to the side-nav button. So something was wrong with the point location calculation.
Setting an implicit wait period did not work. An explicit wait period did not work either. One thing that really sucks about wait code is that it swallows the exception so you don’t see the actual problem. (You are ignoring the exception and not logging it.) So when it fails, all you know is that it did not work for X seconds; not why.
The third issue is that the Selenium isVisible() method checks the element values but does not actually check to see if the element has been scrolled into view. Playwright does it correctly (my interpretation of “isVisible” is literal). Playwright also automatically scrolls elements into view when you try and act upon them. Very nice.
So I had 3 immediate frustrations with Selenium that Playwright took care of.
I sat back and googled some more. I found a video I liked where the speaker asserted that there was no comparison between the two.
At this point I was inclined to agree with him. And I’d invested a day to verify I was making the best decision. Out with Selenium. In with Playwright.
Now I am not saying Playwright is without difficulties. The codegen tool is a miss more than a hit when I use it to try and auto-code the Locators. And I believe I have found a bug where it just fails to work correctly with chromium. That was a huge frustration that cost a week of stoppage hell until I ran out of ideas and tried firefox instead of chromium. Firefox worked, and I was able to start moving again.
For photo work, I use Aurora HDR 2019 and Gimp. Within Gimp, I use the GMIC plugin a great deal, as it has the best noise reduction and hot pixel reduction.
The one big weakness of Gimp is lack of batch mode. You cannot record some action on an individual image, then save that action and apply it to a group of images.
And I do a lot of work on groups of images.
There is a heavy duty script processing engine in gimp, but I find it inaccessible. And I’m a programmer! The basic problem is that I am a lazy programmer and I really don’t need another language unless I really need another language.
I’ve done practically no BIMP. The basic operations that BIMP provides I can can do in Irfanview.
Well I found myself needing to remove the hot pixels of a few hundred photos. The gmix function is remove_hotpixels. But this is the first time I have seen this documentation and the example is confusing. After reading this I thought I needed to write:
+remove_hotpixels _mask_size=3, _threshold=10,
And I tried many many options and nothing worked.
However, some of the simpler commands worked, so I knew it was just a matter of finding the right syntax.
This post is to record what worked. The image below shows the successful Bimp settings. (Except the input field would not expand.)
The function name is plug-in-gmic-qt
The input layer is something besides 0 (holy crap, that just generated out with no changes whatsoever and was a real pita to figure out)
The output mode is 0. Maybe some other options work but 0 works.
The command line string is “remove_hotpixels 3 10“, where 3 is the mask size and 10 is the threshold.
Don’t use a “plus” or “minus”. Don’t name your arguments
Well that is it so far. Another inch of knowledge.
ย
Update from 2020:
ย
Well, I have given up trying to run batch gmic from within gimp. Too much of a hassle, too iffy, and far too slow.
Instead, I installed gmic, the command line tool. You can find it at https://gmic.eu/download.html.
Better to have a horrendously hard to figure out uphill battle from the command line than the same thing from within a clunky gimp dialog.
The positive from using a command line is that we have well known tools for iterating over multiple files. This is important because the “iterating over multiple files” part of the gmic command line doesn’t seem to exist. I can only figure out how to write a gmic script to read one file and write one file.
I can’t yet even figure out how to tell gmic to read a jpg and write a tiff.
But the “remove hit pixels” command is (on a windows platform, using “cmd”):
for /r %f in (.\*) do gmic %f ^ -remove_hotpixels 3,10,,,Merged ^ -o %f
From the command line, cd to the folder containing the files you want to convert and paste the above text. It will recursively find all files in this folder and all sub-folders. It will open each file, run the “remove hotpixels 3,10” command, then save over the same file. And it will do it orders of magnitude faster than the same thing in gimp with bimp.
I also find anisoptropic smoothing to be very useful. It is a nightmare trying to find the right combination of arguments to a gmic command. The best wayย is to setup the command in gimp then alter the settings to display the arguments. Still a pita, as you have to eyeball the text and re-type it into the command line; copy-paste does not work.
Here is a starting point for anisotropic smoothing:
for /r %f in (.\*) do gmic %f ^ -fx_smooth_anisotropic 80,0.7,0.3,0.6,1.1,0.8,30,2,2,0,1,0,0,50,50 ^ -o %f
The actual settings are listed here, but good luck converting the argument types to the integer command line values.
ย
Not sure where the best documentation and tutorials for gmic are. Everything I have found requires you to know what everything means before being able to do anything. More notes added here as I learn.
The death of Chester Williams hit me very, very hard today. I’ve written before how much the World Cup Final between South Africa and New Zealand mattered … the subject of the movie Invictus. And how important Chester was to that victory and the future of South Africa. In how he delivered the first big tackle to Jonah Lomu that set the tone for the entire game. It was at that moment I began to believe we could somehow win. Chester carried a heavy weight on his shoulders as the sole black on the team. People worried he was a “token player” and it was a fair concern because he was the first black to make it. I’d been studying him intensely all tournament (who hadn’t?) and knew he deserved to be there. But sports can be cruel and heroics seemed too much to hope for. Then, as I saw Lomu shudder and collapse, I began to hope and believe … and hope and believe … and then simply hoped and prayed and hung on until the end … like all the players on both sides. The greatest game of all time in which no one could score.
I cried like a baby after that game — the only game that ever mattered so much — and the deepest tears were because of Chester. If we’d won but he’d been a liability on the field, it would have been a setback to a country’s future. Instead, he had the game of a lifetime. And whites experienced pride and love for the gift of a black man’s pure courage in an arena that they understood viscerally. Many for the first time. The celebration of Chester was perhaps the first, honest, positive feeling that all colours could experience together.
I am sorry he died so young. But he is a legend and had 24 years of that knowledge. I will never forget my admiration of and debt to him.
I’ve had support communication with Aurora about problems reading Sony RX10M4 RAW files, which they claim to handle. At the time, I was complaining about invalid cropping: The corners of a RAW image containing vignetting (the dark edges), and Aurora did not remove it. Aurora support said that this is normal operation.
The following image shows this artifact. Same image in RAW and JPG processed by Auror without any subsequent processing. On the left is the RAW image and you can see the vignetting. On the right is the JPG image and you can see the vignetting was cropped and the image was enlarged to the same pixel dimensions.
Note that the JPG image was generated by the camera, i.e., I am saving in RAW+JPG format.
I also use the Sony Imaging Edge app to read RAW images on the computer and save them to JPG. When I do this with the RAW image, I get the identical JPG that is stored on the camera. So this tell me that Imaging Edge DOES choose to apply the vignetting when converting RAW.
Well I can live with this decision by Aurora. But that isn’t the full story. As you can tell, the above images are not the same otherwise. For example, the colors are different. Perhaps this is due to Aurora having better information from the RAW images and making more informed decisions. I can live with this too, if it is true. Color can be altered.
It is when you get to the details that the serious problems appear: 1. Aurora has made different decisions about the cropping/expansion. 2. The RAW image has bad noise artifacts. 3. The RAW image has chromatic aberrations.
Remember that the RAW image is stored with all the imperfections: The sensor itself has noise artifacts, chromatic and lens aberrations. But the RAW image also contains the information that lets the processor compensate for them. Aurora is not doing so.
Look at a close-up image. Below is a portion of the tent on the left-hand-side. On the left the RAW image processed by Aurora. On the right is the exact same region from the JPG image.
ย
First, we see that we have different shapes. This is what leads me to suspect that Aurora is not using the lens information to correct for it. (I am assuming that Imaging Edge IS correcting for it, as well as the in-camera software.)
Second, look at the noise. The RAW image contains a lot of noise. In comparison, the JPG has eliminated that noise, but now has JPG noise artifacts.
Another close-up image below, showing the noise problem again AND the chromatic problem. On the left, the RAW images show serious color error along the borders. The JPG image does not.
If Aurora is doing “correct” RAW image processing, I don’t want it. (This is why I am currently saving in RAW+JPG and only working with the RAW when I absolutely have to.) But really, I am seeing so many issues that I am not convinced that Aurora is processing the RAW correctly.
Back to tech support …
…Back from tech support. Confirmation that this is a bug.
Much to learn about Aurora HDR 2019 still. This particular problem is that it is importing a set of bracketed images into an HDR and the starting point has blowouts, i.e., the whites are crushed to 100% and information is lost forever.
Below is a set of 9 images. These are bracketed exposures, with 1 EV separation.
After import into Aurora, this is what I see:
Notes: Actually importing the RAW images. auto-alignment, ghost reduction, color denoise, chromatic aberration reduction all turned off.
Ignore the vignettes. This is a separate issue I am dealing with (Aurora processes the RAW information but does not do lens correction).
I have “white highlighting” turned on. All the red areas in the image are 100% white, i.e., crushed/blown-out. If you look closely at the histogram, you will see a vertical line at the 100% mark. That is a problem.
That vertical line and the red splotches means that information is lost and cannot be recovered. No amount of adjustments in Aurora will let me fix this.
An HDR should not do this. This is a bug in the tool. We know for a fact that at least 1 (actually more than 1) image in the set is not blown out at these location. That information must be retained for further editing.
(Note: I proved that fact by importing only the darkest image into Aurora and noting that there were no blowouts.)
I could probably fix this by removing one or more of the over-exposed images and re-importing. But that isn’t the solution.
We’ll see what Aurora support has to say about it.